Backups not incremental for chrooted domains

wechselbalg · February 10, 2024, 6:56pm

SYSTEM INFORMATION
OS type and version	Ubuntu Linux 22.04.3
Webmin version	2.105
Virtualmin version	7.9.0

Hi, I may have been stumbled upon a bug in handling chrooted domains. These domains do not appear to create real incremental backups with the builtin backup system.
Files (mails, html files, …) which are included in the full backup will be included again in the incremental one a day or so later though they weren’t changed.

It seems that this part which is called by collectinfo.pl through cron is responsible:

github.com

virtualmin/virtualmin-gpl/blob/406cc4d60e3cefc1f05ee98bfd98faacbd533908/jailkit-lib.pl#L332


      
          foreach my $zdir ("/usr/share/zoneinfo") {
          	next if (!-d $zdir);
          	&make_dir($dir.$zdir, 0755, 1) if (!-d $dir.$zdir);
          	&copy_source_dest($zdir, $dir.$zdir);
          	}
          
          $d->{'jail_last_copy'} = time();
          return undef;
          }
          
          # copy_all_domain_jailkit_files()
          # For all domains with a jail enabled and which haven't copied files in the
          # last 24 hours, copy them now
          sub copy_all_domain_jailkit_files
          {
          foreach my $d (&list_domains()) {
          	next if ($d->{'parent'});
          	my $dir = &domain_jailkit_dir($d);
          	next if (!$dir || !-d $dir);
          	if ($config{'jail_age'} &&
          	    time() - $d->{'jail_last_copy'} > $config{'jail_age'}*3600) {

This function copies all jail-files in the chrooted domain every 24h and chmod the files with g-w:

github.com

virtualmin/virtualmin-gpl/blob/406cc4d60e3cefc1f05ee98bfd98faacbd533908/jailkit-lib.pl#L299


      
          foreach my $sect ("perl", "basicshell", "extendedshell", "ssh", "scp", "sftp",
          		  "editors", "netutils", "php", "logbasics",
          		  split(/\s+/, $config{'jail_sects'}),
          		  split(/\s+/, $d->{'jail_esects'})) {
          	my $cmd = "jk_init -f -j ".quotemeta($dir)." ".$sect;
          	my ($out, $err);
          	&execute_command($cmd, undef, \$out, \$err);
          	if ($?) {
          		return &text('jailkit_einit', $err);
          		}
          	&system_logged("chmod -R g-w ".quotemeta($dir)."/*");
          	}
          
          # Use jk_cp to copy in any other files/directories
          foreach my $jail_cmd (split(/\s+/, $d->{'jail_ecmds'})) {
          	my $jail_cmd_real = &has_command($jail_cmd);
          	next if (!$jail_cmd_real && $jail_cmd !~ /^\/\S+$/);
          	my $cmd = "jk_cp -j ".quotemeta($dir)." -f ". ($jail_cmd_real || $jail_cmd);
          	my ($out, $err);
          	&execute_command($cmd, undef, \$out, \$err);
          	if ($?) {

"/*" includes the home-directory and changes the ctime of all files therein. Incremental Backup uses tar which then includes them again in the backup.

Could the home-directory be excluded from the chmod? I don’t see a reason why it has to be included.

Thanks.

wechselbalg · February 15, 2024, 12:06am

Should I maybe post this as an issue in github?

RobertoPastor · February 15, 2024, 9:09am

Hi,
We are facing the same problem. See this thread: Incremental backup same size of full backup

wechselbalg · February 15, 2024, 11:07am

Do you use chrooted (jailed) Domains?

RobertoPastor · February 15, 2024, 11:29am

Yes. All our domains are chrooted.

shoulders · February 15, 2024, 11:32am

I would post this in GitHib and put a link to the thread there.

nikkio · February 16, 2024, 8:20am

I have the same issue, with chrooted Domains.

system · April 16, 2024, 8:20am

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.