UI bug in virtual server search result tree

[calport]

SYSTEM INFORMATION
OS type and version	Debian Linux 11
Webmin version	2.610
Usermin version	2.510
Virtualmin version	7.50.2 GPL
Theme version	26.20
Apache version	2.4.66
Package updates	5 package updates are available

I just dodged a bullet. I almost deleted a sub server belonging to one virtual server because it incorrectly displayed as a sub server of another virtual server when search is used in the virtual server dropdown box.

In this instance, chandra.hirjee.com is actually a sub server under tiki18.vps15.indiax.com but when search is used, it shows as a sub server of tech-bridge.leadsnap.indiax.com, quite incorrectly.

[stefan1959]

The search only show what you searching for “ch” not the relations between server and subserver. The server dosn’t have “ch”, so is that a bug?

[Joe]

Yeah, this is working as intended (you’re seeing every site with ch in the name as you searched for, and the parent of that name doesn’t have a ch in it), but I can see how that would be confusing. I’m not sure how to best resolve that confusion, though…if search shows the parent no matter what, it’s going to show something that doesn’t actually match the query term, which is bug-like.

Maybe it should show the parent greyed out or something? I dunno. Messy problem.

[Ilia]

@Joe

Maybe it should show the parent greyed out or something? I dunno. Messy problem.

Yeah, I don’t see a clear solution to this either.

[shoulders]

use borders to show grouping.

in the example below I show how grouping can Identify which parent the sub-server belongs to, if shown.

each border represents a parent virtual server.

PS This layout is not accurate to the OPs issue, it is just an example.

[ID10T]

Is there a confirmation screen when deleting? Could it be handled there?

[CTS]

I believe there is a “are you sure you want to delete” confirmation so dodging a bullet is a bit misleading

[Joe]

You can’t delete directly from the domain selection menu…when you select it, it takes you to that domain/subserver/alias. And, yes, there is a confirmation page. It’s easy to zone out while doing repetitive tasks or whatever, and I’ve messed up by not stopping and looking at things…it’s not at all unbelievable that one might be clicking around and think you’re somewhere you’re not.

I just still don’t know how to solve it in this particular case without introducing other problems.

[ID10T]

Auto complete based solely on the server list?

[Ilia]

@Joe

I just still don’t know how to solve it in this particular case without introducing other problems.

I agree. Once, I was just one click away from accidentally deleting a production domain in the same way, so I implemented a “Prevent deletion or disabling” feature on the “Edit Virtual Server” page.

I recommend enabling it if you’re worried about accidentally deleting the wrong domain.

[ID10T]

Make it two step? You must disable a domain before deletion?

[Joe]

It is already two steps, you click delete and then click confirm. Forcing it to be disabled makes it three steps. At some point we have to let users do what they want to do.

[ID10T]

I guess it is my way of thinking. I have a disabled server because I’m kinda gun shy about this kind of thing. Now that someone else has the domain name and I have the backups I guess I should delete it finally.

[Stegan]

@ID10T

I guess it is my way of thinking. I have a disabled server because I’m kinda gun shy about this kind of thing. Now that someone else has the domain name and I have the backups I guess I should delete it finally.

I would make sure that the ‘someone else’ is fully aware of that step (especially if you are on the last resort goto of their disaster recovery plan)