Problems with pro upgrade

danboid · January 14, 2022, 11:58am

SYSTEM INFORMATION

OS type and version:	Ubuntu 18.04
Webmin version:	1.984
Virtualmin version:	6.17-3 Pro

My first question as a new pro user is, is there not a bug tracker for virtualmin and webmin? Surely these forums don’t double up as the bug tracker too?

We purchased a pro license today. I would’ve preferred to upgrade from vmin GPL to Pro via the terminal instead of via the web interface but running the recommended upgrade command failed for me:

virtualmin change-license --serial XXXXXXX --key XXXXXXXXXX
Updating Virtualmin APT repository ..
.. no lines for software.virtualmin.com found!

Updating Virtualmin license file ..
.. done

After running that command, I logged into vmin and indeed it had not yet upgraded to pro so I tried updating via the web interface and then it started downloading new packages but it did so without any warning. At this point, I think vmin should warn the user what is about to happen ie that several large packages are about to be downloaded and installed and so they should probably schedule downtime to do the upgrade. Make the user agree to this before letting the upgrade proceed.

The website says the pro upgrade can be done without a re-install but if you have to add a new repo and the download/upgrade/replace several large packages then this is pretty close to doing a re-install.

I’m currently unsure if the upgrade has failed because it has been stuck on the line

Setting up webmin-virtual-server (6.17.pro-3) …

For well over 15 minutes now. Could that step take some time on a machine with hundreds of domains?

danboid · January 14, 2022, 12:18pm

It seems the bugs are to be reported Virtualmin · GitHub

but there are 47 repos there! This is probably 2 or 3 separate bugs but which repo would I file them under?

Ilia · January 14, 2022, 12:58pm

Hi,

I would’ve preferred to upgrade from vmin GPL to Pro via the terminal instead of via the web interface but running the recommended upgrade command failed for me.

There was a bug which was already fixed. In the future, the script will explicitly tell you what the problem is, if upgrade is tried to be performed from CLI:

root@debug-debian10-gpl:~# virtualmin change-license --serial 0000000 --key aaBBCCccCC
GPL repos detected. Use `System Settings ⇾ Upgrade to Virtualmin Pro` in UI instead to upgrade first!

Updates the Virtualmin Pro license for this system.

virtualmin change-licence --serial number
                          --key id
                         [--no-check]
                         [--force-update]

so they should probably schedule downtime to

No, upgrading packages results in no downtime. Those steps are done to upgrade packages to Virtualmin Pro.

The website says the pro upgrade can be done without a re-install but if you have to add a new repo and the download/upgrade/replace several large packages then this is pretty close to doing a re-install.

No, no. Not at all.

I’m currently unsure if the upgrade has failed because it has been stuck on the line

Perhaps, you were running Webmin behind proxy, and it reached allowed request timeout and then the connection was closed? This issue shouldn’t happen.

Could that step take some time on a machine with hundreds of domains?

It should be happening faster than 15 minutes but it may depend though.

If some packages upgrade failed, it’s not a problem. Check if repo files were updated correctly, and simply re-run apt-get update && apt-get upgrade.

it started downloading new packages but it did so without any warning.

I think this is a great suggestion. @Jamie @Joe I also believe we must tell the user and let the user choose on Upgrade to Virtualmin Pro page, with checkboxes to opt-out from installing any extra virtualmin-* packages.

Although we need to add Pro repos first to be able to list packages from. Then we probably shouldn’t install any and in the end of the installation process list additional available packages with description about which package does what and let an admin decide which packages are installed.

I think upgrade should be as little invasive as possible, as it asks to upgrade to Pro not to install loads of packages as well.

danboid · January 14, 2022, 1:05pm

Thankfully, although the upgrade looked like it had stalled, I think it did actually go OK because webmin is telling me I’m runing the pro version and apt update / upgrade isn’t reporting any errors.

Here is the complete output from the web interface upgrade. I expect there were more steps but they never got printed to webmin upgrade console output window:

Upgrade to Virtualmin Pro

Creating Virtualmin license file ..
.. done

Updating available packages from APT ..

Hit:1 https://packages.microsoft.com/ubuntu/18.04/prod bionic InRelease
Hit:2 http://ppa.launchpad.net/ondrej/php/ubuntu bionic InRelease
Hit:3 http://azure.archive.ubuntu.com/ubuntu bionic InRelease
Get:4 http://azure.archive.ubuntu.com/ubuntu bionic-updates InRelease [88.7 kB]
Get:5 http://azure.archive.ubuntu.com/ubuntu bionic-backports InRelease [74.6 kB]
Get:6 http://security.ubuntu.com/ubuntu bionic-security InRelease [88.7 kB]
Get:7 https://software.virtualmin.com/vm/6/apt virtualmin-bionic InRelease [10.7 kB]
Hit:8 http://repo.zabbix.com/zabbix/4.0/ubuntu bionic InRelease
Get:9 https://software.virtualmin.com/vm/6/apt virtualmin-universal InRelease [10.7 kB]
Get:10 https://software.virtualmin.com/vm/6/apt virtualmin-bionic/main all Packages [10.2 kB]
Get:11 https://software.virtualmin.com/vm/6/apt virtualmin-bionic/main amd64 Packages [10.8 kB]
Get:12 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 Packages [43.8 kB]
Get:13 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main all Packages [43.8 kB]
Fetched 382 kB in 2s (171 kB/s)
Reading package lists...
.. done


Upgrading Virtualmin Debian packages : usermin usermin-virtual-server-mobile webmin webmin-virtual-server=6.17.pro-3 webmin-virtual-server-mobile webmin-virtual-server-theme webmin-virtualmin-awstats webmin-virtualmin-dav webmin-virtualmin-disable webmin-virtualmin-git webmin-virtualmin-google-analytics webmin-virtualmin-htpasswd webmin-virtualmin-iframe webmin-virtualmin-init webmin-virtualmin-mailman webmin-virtualmin-mailrelay webmin-virtualmin-messageoftheday webmin-virtualmin-nginx webmin-virtualmin-nginx-ssl webmin-virtualmin-notes webmin-virtualmin-oracle webmin-virtualmin-password-recovery webmin-virtualmin-powerdns webmin-virtualmin-registrar webmin-virtualmin-signup webmin-virtualmin-slavedns webmin-virtualmin-sqlite webmin-virtualmin-styles-oswd webmin-virtualmin-support webmin-virtualmin-svn webmin-virtualmin-vsftpd

Reading package lists...
Building dependency tree...
Reading state information...
usermin is already the newest version (1.834).
webmin is already the newest version (1.984).
webmin-virtualmin-awstats is already the newest version (5.11).
webmin-virtualmin-dav is already the newest version (3.13).
webmin-virtualmin-git is already the newest version (1.15).
webmin-virtualmin-htpasswd is already the newest version (3.0).
webmin-virtualmin-init is already the newest version (2.10).
webmin-virtualmin-password-recovery is already the newest version (1.12).
webmin-virtualmin-registrar is already the newest version (2.10).
webmin-virtualmin-slavedns is already the newest version (1.13).
webmin-virtualmin-sqlite is already the newest version (1.8).
The following packages were automatically installed and are no longer required:
  linux-azure-5.4-cloud-tools-5.4.0-1059
  linux-azure-5.4-cloud-tools-5.4.0-1063 linux-azure-5.4-headers-5.4.0-1059
  linux-azure-5.4-headers-5.4.0-1063 linux-azure-5.4-tools-5.4.0-1059
  linux-azure-5.4-tools-5.4.0-1063
Use 'apt autoremove' to remove them.
The following NEW packages will be installed:
  usermin-virtual-server-mobile webmin-virtual-server-mobile
  webmin-virtual-server-theme webmin-virtualmin-disable
  webmin-virtualmin-google-analytics webmin-virtualmin-iframe
  webmin-virtualmin-mailman webmin-virtualmin-mailrelay
  webmin-virtualmin-messageoftheday webmin-virtualmin-nginx
  webmin-virtualmin-nginx-ssl webmin-virtualmin-notes webmin-virtualmin-oracle
  webmin-virtualmin-powerdns webmin-virtualmin-signup
  webmin-virtualmin-styles-oswd webmin-virtualmin-support
  webmin-virtualmin-svn webmin-virtualmin-vsftpd
The following packages will be upgraded:
  webmin-virtual-server
1 upgraded, 19 newly installed, 0 to remove and 0 not upgraded.
Need to get 11.6 MB of archives.
After this operation, 7465 MB of additional disk space will be used.
Get:1 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 usermin-virtual-server-mobile all 2.1 [64.0 kB]
Get:2 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtual-server all 6.17.pro-3 [4281 kB]
Get:3 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtual-server-mobile all 2.6 [67.4 kB]
Get:4 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtual-server-theme all 9.4 [2287 kB]
Get:5 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-disable all 1.7 [25.2 kB]
Get:6 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-google-analytics all 2.12 [104 kB]
Get:7 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-iframe all 1.5 [14.8 kB]
Get:8 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-mailman all 6.9 [124 kB]
Get:9 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-mailrelay all 2.5 [75.4 kB]
Get:10 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-messageoftheday all 1.4 [3358 B]
Get:11 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-nginx all 2.23 [316 kB]
Get:12 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-nginx-ssl all 1.16 [36.8 kB]
Get:13 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-notes all 1.7 [18.9 kB]
Get:14 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-oracle all 1.14 [126 kB]
Get:15 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-powerdns all 1.13 [42.8 kB]
Get:16 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-signup all 1.8 [49.0 kB]
Get:17 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-styles-oswd all 1.0 [3778 kB]
Get:18 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-support all 2.4 [82.8 kB]
Get:19 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-svn all 5.1 [42.2 kB]
Get:20 https://software.virtualmin.com/vm/6/apt virtualmin-universal/main amd64 webmin-virtualmin-vsftpd all 1.11 [36.9 kB]
[master 90c5c8bdc] saving uncommitted changes in /etc prior to apt run
 Committer: root <root@poseidon>
Your name and email address were configured automatically based
on your username and hostname. Please check that they are accurate.
You can suppress this message by setting them explicitly. Run the
following command and follow the instructions in your editor to edit
your configuration file:

    git config --global --edit

After doing this, you may fix the identity used for this commit with:

    git commit --amend --reset-author

 17 files changed, 42 insertions(+), 41 deletions(-)
 create mode 100644 apt/auth.conf.d/virtualmin.conf
debconf: unable to initialize frontend: Dialog
debconf: (TERM is not set, so the dialog frontend is not usable.)
debconf: falling back to frontend: Readline
debconf: unable to initialize frontend: Readline
debconf: (This frontend requires a controlling tty.)
debconf: falling back to frontend: Teletype
dpkg-preconfigure: unable to re-open stdin: 
Fetched 11.6 MB in 5s (2401 kB/s)
Selecting previously unselected package usermin-virtual-server-mobile.
(Reading database ... 
(Reading database ... 5%
(Reading database ... 10%
(Reading database ... 15%
(Reading database ... 20%
(Reading database ... 25%
(Reading database ... 30%
(Reading database ... 35%
(Reading database ... 40%
(Reading database ... 45%
(Reading database ... 50%
(Reading database ... 55%
(Reading database ... 60%
(Reading database ... 65%
(Reading database ... 70%
(Reading database ... 75%
(Reading database ... 80%
(Reading database ... 85%
(Reading database ... 90%
(Reading database ... 95%
(Reading database ... 100%
(Reading database ... 303550 files and directories currently installed.)
Preparing to unpack .../00-usermin-virtual-server-mobile_2.1_all.deb ...
Unpacking usermin-virtual-server-mobile (2.1) ...
Preparing to unpack .../01-webmin-virtual-server_6.17.pro-3_all.deb ...
Unpacking webmin-virtual-server (6.17.pro-3) over (6.17.gpl-3) ...
Selecting previously unselected package webmin-virtual-server-mobile.
Preparing to unpack .../02-webmin-virtual-server-mobile_2.6_all.deb ...
Unpacking webmin-virtual-server-mobile (2.6) ...
Selecting previously unselected package webmin-virtual-server-theme.
Preparing to unpack .../03-webmin-virtual-server-theme_9.4_all.deb ...
Unpacking webmin-virtual-server-theme (9.4) ...
Selecting previously unselected package webmin-virtualmin-disable.
Preparing to unpack .../04-webmin-virtualmin-disable_1.7_all.deb ...
Unpacking webmin-virtualmin-disable (1.7) ...
Selecting previously unselected package webmin-virtualmin-google-analytics.
Preparing to unpack .../05-webmin-virtualmin-google-analytics_2.12_all.deb ...
Unpacking webmin-virtualmin-google-analytics (2.12) ...
Selecting previously unselected package webmin-virtualmin-iframe.
Preparing to unpack .../06-webmin-virtualmin-iframe_1.5_all.deb ...
Unpacking webmin-virtualmin-iframe (1.5) ...
Selecting previously unselected package webmin-virtualmin-mailman.
Preparing to unpack .../07-webmin-virtualmin-mailman_6.9_all.deb ...
Unpacking webmin-virtualmin-mailman (6.9) ...
Selecting previously unselected package webmin-virtualmin-mailrelay.
Preparing to unpack .../08-webmin-virtualmin-mailrelay_2.5_all.deb ...
Unpacking webmin-virtualmin-mailrelay (2.5) ...
Selecting previously unselected package webmin-virtualmin-messageoftheday.
Preparing to unpack .../09-webmin-virtualmin-messageoftheday_1.4_all.deb ...
Unpacking webmin-virtualmin-messageoftheday (1.4) ...
Selecting previously unselected package webmin-virtualmin-nginx.
Preparing to unpack .../10-webmin-virtualmin-nginx_2.23_all.deb ...
Unpacking webmin-virtualmin-nginx (2.23) ...
Selecting previously unselected package webmin-virtualmin-nginx-ssl.
Preparing to unpack .../11-webmin-virtualmin-nginx-ssl_1.16_all.deb ...
Unpacking webmin-virtualmin-nginx-ssl (1.16) ...
Selecting previously unselected package webmin-virtualmin-notes.
Preparing to unpack .../12-webmin-virtualmin-notes_1.7_all.deb ...
Unpacking webmin-virtualmin-notes (1.7) ...
Selecting previously unselected package webmin-virtualmin-oracle.
Preparing to unpack .../13-webmin-virtualmin-oracle_1.14_all.deb ...
Unpacking webmin-virtualmin-oracle (1.14) ...
Selecting previously unselected package webmin-virtualmin-powerdns.
Preparing to unpack .../14-webmin-virtualmin-powerdns_1.13_all.deb ...
Unpacking webmin-virtualmin-powerdns (1.13) ...
Selecting previously unselected package webmin-virtualmin-signup.
Preparing to unpack .../15-webmin-virtualmin-signup_1.8_all.deb ...
Unpacking webmin-virtualmin-signup (1.8) ...
Selecting previously unselected package webmin-virtualmin-styles-oswd.
Preparing to unpack .../16-webmin-virtualmin-styles-oswd_1.0_all.deb ...
Unpacking webmin-virtualmin-styles-oswd (1.0) ...
Selecting previously unselected package webmin-virtualmin-support.
Preparing to unpack .../17-webmin-virtualmin-support_2.4_all.deb ...
Unpacking webmin-virtualmin-support (2.4) ...
Selecting previously unselected package webmin-virtualmin-svn.
Preparing to unpack .../18-webmin-virtualmin-svn_5.1_all.deb ...
Unpacking webmin-virtualmin-svn (5.1) ...
Selecting previously unselected package webmin-virtualmin-vsftpd.
Preparing to unpack .../19-webmin-virtualmin-vsftpd_1.11_all.deb ...
Unpacking webmin-virtualmin-vsftpd (1.11) ...
Setting up webmin-virtualmin-nginx (2.23) ...
virtualmin-nginx
Setting up webmin-virtualmin-mailrelay (2.5) ...
virtualmin-mailrelay
Setting up webmin-virtualmin-notes (1.7) ...
virtualmin-notes
Setting up webmin-virtual-server (6.17.pro-3) ...

Ilia · January 14, 2022, 1:26pm

You would need Virtualmin GPL repo to file a bug.

The following NEW packages will be installed:
usermin-virtual-server-mobile webmin-virtual-server-mobile
webmin-virtual-server-theme webmin-virtualmin-disable
webmin-virtualmin-google-analytics webmin-virtualmin-iframe
webmin-virtualmin-mailman webmin-virtualmin-mailrelay
webmin-virtualmin-messageoftheday webmin-virtualmin-nginx
webmin-virtualmin-nginx-ssl webmin-virtualmin-notes webmin-virtualmin-oracle
webmin-virtualmin-powerdns webmin-virtualmin-signup
webmin-virtualmin-styles-oswd webmin-virtualmin-support
webmin-virtualmin-svn webmin-virtualmin-vsftpd

This is overkill. I will look into reducing the number of packages which are installed upon upgrading to Pro. 99% chance that none of those will ever be needed.

Joe · January 14, 2022, 2:03pm

Oh, hell, it shouldn’t be doing anything but install the Pro virtual-server package. I don’t know why it’s installing all that other stuff.

Ilia · January 14, 2022, 2:14pm

Yes, agreed. I will fix that.

Ilia · January 14, 2022, 7:03pm

Alright, this has been fixed. It will only install Virtualmin Pro package. Nothing else.

Also, it will not print output unless there were errors and the successful upgrade process will look as simple as:

Finally, if upgrade fails for some reason, it will be possible to restart it later.

system · January 22, 2022, 7:03pm

This topic was automatically closed 8 days after the last reply. New replies are no longer allowed.