Debian Linux 12 kernel Linux 6.1.0-49-amd64 on x86_64
Webmin version
2.651
Hi,
In System > System logs > Messages for specific unit,
a char is rendered as ◦ in the drop-down unit selector menu.
I also noticed it in the previous version of Webmin (and thought this version fixed the bug).
The bug appears both on my WS and on my server (same OS, same version, same Webmin version).
I didn’t recently install nor remove packages on my systems except those required by security updates.
It’s not critical at all since the log viewer works fine, as usual. I declare the bug because it’s not nice and it may be the symptom of something worse.
Thanks in advance,
Bleck
No need to try any other browsers. We added a call to a function to escape values being passed to ui_select to prevent some types of stored XSS risks, and it turns out there’s at least one place where that has a surprising effect.
The original code is probably the bug-like here, actually. If we give the actual raw entity value, it passes through untouched. And, I’m not sure I like the mystery meat indicator here. What does the circle mean? Why is there a circle?
Well, yeah, maybe. But removing it entirely doesn’t look too good either. We could use -, but that won’t solve it in terms of being seen as subitems of “Kernel messages”.
And, I think originally I kept the circle because it goes well with what systemd does, e.g.:
~# systemctl status webmin
● webmin.service - Webmin server daemon
Loaded: loaded (/usr/lib/systemd/system/webmin.service; enabled; preset: enabled)
....
- is worse. Doesn’t solve either problem. Still looks like a subitem of kernel messages, still doesn’t have any obvious meaning, and is kinda uglier than the circle.
I guess we’ll leave it alone for now, but this UI probably ought to get an overhaul. The super long dropdown is uncomfortable for reasons other than the mystery meat Unicode circle.