Keep previous version of Authentic Theme (to test possible memory leak)

I have dug in even more and this time I believe I have fixed it completely!

At least can anyone reading this please check and test it once more?

To apply all the latest patches please run the following:

webmin patch https://github.com/webmin/webmin/commit/0ac51a8
webmin patch https://github.com/webmin/authentic-theme/commit/fd51ab9
webmin patch https://github.com/webmin/authentic-theme/commit/c3a6564
webmin patch https://github.com/webmin/authentic-theme/commit/c3098fe
webmin patch https://github.com/webmin/authentic-theme/commit/07efdf1

If that doesn’t work for whatever reason, the other easiest way to try it would be is to install latest devel version of Webmin, by directly downloading DEB or RPM file and installing it by running:

apt-get install ./webmin-latest.deb

or

dnf install ./webmin-latest.rpm

* Note that this is an automated pre-release development build. Later Webmin 2.202+ releases will automatically install over this build with no any issues.

1 Like

Applied, observing

Thank you! Appreciate it!

I have the very last one please:

webmin patch https://github.com/webmin/authentic-theme/commit/e71bad

I’m done for today. I will look for your results tomorrow. Though, I’m running my own as well on all servers I have.

1 Like

All my results ran throughout the night appeared to be beyond great!! stats.pl is no longer bubbling and also releases the memory it used! I’m pretty happy!

I also think and hope you have had the same results?? :blush:

1 Like

Since installing the patches yesterday I see no signs of the memory leak and it seems to me to be solved.

I do have the lesser display problem - of the CPU dial freezing and the graphs not drawn, but wait to see if someone else reports it. I noticed it since the first patch but also after reverting to the 21.20.3 version, and did try using another browser, disabling ad-block, clearing cache etc.

Tl;dr : it works, but it took a few tries

So, when I applied the patches as instructed, it broke stats.pl . I saw it appear as a running process a few times but then it would disappear. I suspected this isn’t the desired result so I rebuilt the server a few times to retry but it always ended up the same. Then I went with a pre-release build of webmin and it seems to work just fine. Stats.pl is present and in 12 hours went from 100 to 103mb.

As for the dials, I mentioned that exact thing already but I don’t think I did a good job. As of applying this patch the dials do work but it’s like the framerate of the animation is dropping significantly under load, which definitely didn’t happen before. I know Illia said it was normal, but it doesn’t look normal to me. Still, it’s less important than fixing stats.pl memory issue so I consider this a success😊

1 Like

I’m sorry to admit It seems my patching failed and stats.pl wasn’t running on my system, or running periodically, so my feedback should be ignored. This is also why the graphs were not always drawn for me. Installing the development build of webmin seems to solve those problems.

Did you get any output indicating a failure? First time I tried all patches succeeded except the last one, it threw a very long output about failure. I re-tried everything on a rebuilt server and piped the output to individual files and that time every patch reported success, but stats.pl was gone from the process list.

No, I didn’t get any failure notice. All the patches listed one or two replaced files and restarted webmin. I had no indication for failure. But when checking now, I saw stats.pl wasn’t running. Since installing the development build the graphs are drawn again and the dials moving (and actually stats.pl is at the top of the memory users again). So as the graphs were sometimes drawn and sometimes not (but usually not) I understand stats.pl sometimes ran and sometimes not.

That’s odd, I got functional dials even when stats.pl wasn’t present on the process list. I did save a vps snapshot with that state in case patch troubleshooting is needed

Maybe it has something to do with me installing the 21.20.5 Authentic theme using the 21.20.3 theme interface, before applying the patches? I don’t remember if I loaded my machine from backup after the patch, but I later reinstalled the current Webmin over it to return to the 21.20.3 theme. It didn’t help and the display problems continued, so I thought the problem was introduced already in the 21.20.3 theme. The development build has the 21.20.5 theme, but the display works…

Iirs it’s not a good idea to update authentic theme by itself. What you describe could have caused issues, but the same thing happened on my system running 21.20.3

Yes, it also works incredibly well for me. The memory usage fluctuates as it should, not just going up.

I don’t understand the problem. It works perfectly fine to me. Framerate – what do you mean?

Could you make a video screencast?

This is how it works for me:

I don’t see any issue here!

It seems that when UI is used on PC the graphs work ok, but on mobile phones it’s much more “jumpy”. I made a side-by-side video of our two servers for you, but I think the main takeaway here is that “the guts” are ok, eye-candy for phones is less of a priority. Sorry about the color grading, my screens are ultra-dim, you can just disregard that part, there are no issues with colors or brightness- that is specific to my device. I tried to upload directly to the forum but it won’t let me, so here’s a yt link, I hope it helps in some way

Thanks for the feedback!

Sorry about the color grading, my screens are ultra-dim, you can just disregard that part, there are no issues with colors or brightness- that is specific to my device.

This is strictly device-dependent. I don’t have this issue happening on any of my mobile devices.

We can safely ignore it, in my opinion as there is not much I will be able to do about it!

1 Like

You’re welcome. Sorry if I misled you unintentionally, over 90% of work regarding this bug was done on the phone because I wasn’t anywhere near a PC most of the time, hence the twitchy dials.

In any case, is the webmin devel build ready for deployment on our production server? I don’t mind waiting a bit longer for a regular update and killing stats.pl in the meantime if some things need to still be worked out.

Thank you!

No problem!

Development builds are never ready for production servers! :wink:

@Jamie, I believe we can release Webmin 2.202 later today, after I release Authentic 21.20.6.

1 Like

This topic was automatically closed 8 days after the last reply. New replies are no longer allowed.