I made changes to the server block of a virtual server using Virtualmin > Web Configuration > Configure Nginx Website.
Goal was to enable ACME challenge for IPv6 so I had to add those blocks.
Saving worked, and the nginx configs were updated accordingly.
However this did not reload nginx, and I can not find a suitable button for it on the page where the config is saved, or a prompt that this should be needed.
The expectation would really be that after a server block is changed and saved, that nginx reload automatically.
I reloaded manually and then the ACME challenge worked as expected.
Am I missing something and doing this the wrong way, or is it a user experience that can be improved?
If it is the latter, I would almost like to argue that it could be a bug?
I donāt use dark mode so I donāt know if thatās a problem or if the new āeasy on the eyesā theme just makes it impossible to see. On my screen it is a light grey color. It looks darker on the screen shot because it darkens on mouse hover.
The button exists when editing from Webmin, but not from Virtualmin.
And I think expectation would be that edits from Virtualmin should reload nginx automatically if needed to apply the new saved settings.
It is in Virtualmin on the Apache configuration. So, Iād say this is an inconsistency between the two.
This does seem like a reasonable expectation. Iām kinda wondering if there was some thinking about giving a domain owner the ability to reload the configuration. It shouldnāt be a problem if the domain owner is only affecting their own configuration.
I can see where you wouldnāt want to give ārestartā capabilities to each domain owner but reload should be safe enough Iād think.
Not sure if realoding nginx, and the config is bad, would stop nginx entirely?
If so, a reload from a domain owner should be preceeded by something like nginx -t which should return something like syntax is ok and test is successfullat the end, and if it returns something else it should stop the reload and revert the changes with a warning or something like that.
Sure, but that extra step for editing something in one place, and then going to a completely different place to apply it, does not make much sense to me. Although as a work around it is as good as anything else, and better than having to run systemctl reload nginx.
@Jamie and I discussed this before, and even though it might feel unintuitive at first, itās intentional. Making changes to the configuration and applying them are not the same thing, nor should the latter be automatically assumed.
This also reflects how it works when done via the terminal, meaning the configuration is edited first and the service is restarted separately.
Thatās fair, but the page for this in Virtualmin does not have a reload button, so there is no intuitive way of knowing a reload should/need to happen.
If the reload should not be done from Virtualmin to apply a new config, the ability to change and save a new config in Virtualmin should be limited, maybe even not exist?
Lacking both a reload button and a reload indication makes the config save change unintuitive.
