Okay, this issue has been addressed in the patch below. We will discuss internally, if we’re keeping it this way. Nevertheless, it must work flawlessly now for any kind of configs, even broken ones.
Give it a try patching a file and restarting Webmin afterwards.
Note: Line 1834 doesn’t exist on your system, don’t look for it and don’t be surprised it’s not there.
The simple way to apply the patch, is to run the following command (from SSH console or in-built Webmin command line), for Debian/Ubuntu:
You’ll see the ssl_ca attribute is not correct. FWIW, houseofsilnyevents is a deleted account. It was deleted yesterday, and I patched the code just now.
However, there’s still other issues. You’ll see the ssl_ca attribute is not correct.
None of this is longer an issue, and for deleted accounts it will automatically remove all entries from Dovecot config. However, your case displays also an old issue when sharing certificates, which is also considered to be fixed.
Also, you’ll see there’s multiple duplicated lines for azzurec.
None of this will be an issue. Try re-requesting LE SSL certificate and see what happens (with applied patches and restarted Webmin).
The copy/paste above also looks like it’s all on one line even though it’s not because of whatever the non-printable whitespaces were.
That is not something I ever seen. It’s most likely incorrectly edited by human.
Ok, so if it’s considered to be fixed, why is it still happening?
Should I remove all local_name clauses from the dovecot.conf before re-requesting LE SSL certs (after updated patches and restarting webmin of course)?
Considering that you have applied the patch correctly, the only reason why it could be happening is completely broken config. However, missing curly brackets should be fixed only manually.
If it’s happening, share the state of dovecot.conf config file before running LE certificate request, I’d like to have a look.
Fwiw, the only time any config files have been manually edited is when things started breaking. Normally, I let virtualmin/webmin do the heavy lifting.
I will send the dovecot.conf to info@virtualmin.com so that it’s not attached to the public forum or the public ticket.
Please get rid of the ssl_ca lines! I know it’s annoying, we’re working on it, but it’s been known for weeks that the ssl_ca lines are a problem (both for Dovecot and our parser/generator). There is no scenario where the ssl_ca lines should be there. When you fix it manually, you need to get rid of every mention of ssl_ca in those local_name sections.
No. It’s only for those who has old config and wants to help and run extra tests, just in case. If you removed ssl_ca directive you don’t even need patch, it won’t fail.
Just FYI, I created a new Virtual Server today and obtained an SSL cert with no pain and no damage to dovecot.conf . It did create a wildcard for the new site that I didn’t ask for, but that’s fine.
the Virtualmin updates are not fixing this on my system…another client domain hosted on my system performed its regular automatic SSL update last night and once again…missing curly bracket “}” after line 149.
It appears that any lines containing ‘…/ssl.cert’ are also incorrect. The only lines I believe that should be in there are the .key and .combined lines withiin the local_name clause.